Skip to content

Updating directory structure and process script#1995

Open
smarthg-gi wants to merge 5 commits into
datacommonsorg:masterfrom
smarthg-gi:us_nces_demographics_refresh
Open

Updating directory structure and process script#1995
smarthg-gi wants to merge 5 commits into
datacommonsorg:masterfrom
smarthg-gi:us_nces_demographics_refresh

Conversation

@smarthg-gi
Copy link
Copy Markdown
Contributor

@smarthg-gi smarthg-gi commented May 7, 2026

No description provided.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces manifest files for private school demographics and statistics imports and refactors the processing script to support conditional execution via command-line flags. Feedback focuses on including a missing MCF file in the statistics manifest, optimizing the flag-based execution logic to avoid redundant processing, and improving error logging by preserving stack traces.

Comment thread ..._nces/demographics/private_school/private_school_stats/NCES_PrivateSchoolStats/manifest.json
Comment thread scripts/us_nces/demographics/private_school/process.py
Comment thread scripts/us_nces/demographics/private_school/process.py Outdated
@smarthg-gi smarthg-gi force-pushed the us_nces_demographics_refresh branch from ca7404f to 0cc1b51 Compare May 11, 2026 06:15
@smarthg-gi
Copy link
Copy Markdown
Contributor Author

smarthg-gi commented May 11, 2026 •
edited
Loading

@gemini-code-assist

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented May 11, 2026

The refactoring to support separate imports for stats and place data using CLI flags is well-implemented. I noticed one minor improvement: in scripts/us_nces/demographics/private_school/private_school_stats/manifest.json, the curator_emails list is currently empty ([""]). Please ensure this is populated with the appropriate contact email for the dataset.

@smarthg-gi smarthg-gi force-pushed the us_nces_demographics_refresh branch from 904e4bf to f639ef9 Compare May 13, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smarthg-gi